This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Split apart "always show bookmarks toolbar" and the bookmarks toolbar display mode #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might actually make the most sense to have 4 options: /cc @bradleyrichter I think this is an improvement so I'll merge. Mainly it's really confusing seeing a disabled item with an option of "Text only" under bookmarks toolbar. And an option to control it underneath it. But please advise if you'd like a followup to combine into one drop down which I think is the most clean. |
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Split apart "always show bookmarks toolbar" and the bookmarks toolbar display mode
Fixes #4936
Auditors: @bbondy
Test Plan: